Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft-launcher: 2.1.9618 -> 2.1.11314 #78455

Merged
merged 1 commit into from Jan 26, 2020
Merged

minecraft-launcher: 2.1.9618 -> 2.1.11314 #78455

merged 1 commit into from Jan 26, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jan 25, 2020

Motivation for this change

Update minecraft-launcher

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 735,324,992 B -> 739,558,888 B
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cpages, ryantm and infinisil January 25, 2020 08:59
ryantm
ryantm approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • built with nixpkgs-review
  • launched minecraft on NixOs

@ryantm ryantm merged commit 08fa4c6 into NixOS:master Jan 26, 2020
@ryantm
Copy link
Member

ryantm commented Jan 26, 2020

thanks; please consider adding yourself as a maintainer.

@oxalica oxalica deleted the mc-update branch January 26, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@cpages cpages Awaiting requested review from cpages

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxalica @ryantm