Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.10.11 -> 4.11.5 #78574

Merged
merged 3 commits into from Jan 27, 2020
Merged

samba: 4.10.11 -> 4.11.5 #78574

merged 3 commits into from Jan 27, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Jan 26, 2020 •
edited

Motivation for this change

This is a security release in order to address the following defects:

  • CVE-2019-14902: Replication of ACLs set to inherit down a subtree on AD Directory not automatic.
  • CVE-2019-14907: Crash after failed character conversion at log level 3 or above.
  • CVE-2019-19344: Use after free during DNS zone scavenging in Samba AD DC.

More info see: https://www.samba.org/samba/history/samba-4.11.5.html

It is based on #73315 and if merged replaces it.

Things done

Tested on my file server.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @aneeshusa @nh2 @risicle

@nh2
Copy link
Contributor

nh2 commented Jan 27, 2020

Merging; we have a high degree of testing in #73315 and ofborg is happy with the point release upgrade here.

Switching to staging first though because it rebuilds quite a lot of stuff.

@nh2 nh2 changed the base branch from master to staging January 27, 2020 12:39
risicle and others added 3 commits January 27, 2020 13:40
@risicle @nh2
samba: 4.10.11 -> 4.11.3
5e7dc62
@risicle @nh2
samba: remove no-longer-necessary darwin test hack
6e61548 
test is skipped automatically now
@bachp @nh2
samba: 4.11.3 -> 4.11.5
0061075 
This is a security release in order to address the following defects:

- CVE-2019-14902: Replication of ACLs set to inherit down a subtree on AD Directory not automatic.
- CVE-2019-14907: Crash after failed character conversion at log level 3 or above.
- CVE-2019-19344: Use after free during DNS zone scavenging in Samba AD DC.
nh2
nh2 approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #73315.

@nh2 nh2 merged commit 6f1095b into NixOS:staging Jan 27, 2020
@nh2 nh2 mentioned this pull request Jan 27, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @nh2 @risicle