Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lzbench: 20170208 -> 1.8 #78573

Merged
merged 1 commit into from Feb 14, 2020
Merged

lzbench: 20170208 -> 1.8 #78573

merged 1 commit into from Feb 14, 2020

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Jan 26, 2020 •
edited

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
Copy link
Contributor Author

Moredread commented Jan 26, 2020 •
edited

Currently building on a Debian machine I get a segfault when compiling dynamically. Build statically it works.

The static version of glibc was previously in buildInputs, removing that fixes the problem.

@Moredread Moredread requested a review from viric January 26, 2020 21:04
@Moredread Moredread marked this pull request as ready for review January 27, 2020 01:50
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/111

@marsam marsam merged commit 20bc3aa into NixOS:master Feb 14, 2020
@marsam
Copy link
Contributor

marsam commented Feb 14, 2020

Thanks!

@Moredread Moredread deleted the lzbench branch February 14, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @nixos-discourse @marsam