Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020.01.15 -> 2020.01.24 #78433

Merged
merged 1 commit into from Jan 25, 2020
Merged

youtube-dl: 2020.01.15 -> 2020.01.24 #78433

merged 1 commit into from Jan 25, 2020

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jan 24, 2020

Motivation for this change

Release notes - in particular, downloading from youtube itself is currently broken on the previous version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nh2
nh2 approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked changelog, upstream commits and upstream diff sanity.

Indeed previous versions of youtube-dl are broken for me on YouTube, and this fixes it.

Merging.

@nh2 nh2 merged commit f56ca25 into NixOS:master Jan 25, 2020
@arcnmx arcnmx deleted the pr-ytdl-update branch January 25, 2020 03:10
@knedlsepp
Copy link
Member

@nh2 Could you cherry-pick this to stable? :-)

nh2 pushed a commit to nh2/nixpkgs that referenced this pull request Jan 27, 2020
@arcnmx @nh2
youtube-dl: 2019.11.05 -> 2020.01.24
b53ed87 
Fixes downloading from YouTube, see NixOS#78433.

(cherry picked from commit e0e2fd8)
@nh2 nh2 mentioned this pull request Jan 27, 2020
Merged
10 tasks
@nh2
Copy link
Contributor

nh2 commented Jan 27, 2020

@nh2 Could you cherry-pick this to stable? :-)

Done at #78605.

@knedlsepp
Copy link
Member

@nh2 Could you cherry-pick this to stable? :-)

Done at #78605.

Thx! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

@fpletz fpletz Awaiting requested review from fpletz

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcnmx @knedlsepp @nh2