Lua for sile #78432
Lua for sile #78432
Conversation
Now it's a released package so no need to specify the manifest anymore.
|
@teto could you point me to where did my Pulseaudio Lua module got generated? I didn't find it in the diff other then in the csv file... |
|
I haven't committed the generated pulseaudio package (due to this line https://github.com/NixOS/nixpkgs/blame/master/maintainers/scripts/luarocks-packages.csv#L74) but if you run |
|
seems like linenoise needs an override, will update later. |
I remember, that back when I wanted to add lua_pulseaudio to nixpkgs I considered just adding a line to the csv table and running the script. But, I figured that it would just update so many packages that many people would have to be mentioned and summoned for review in order for that PR to pass while I just want my package to be added. Hence, I added it where it is now - to Anyway, I don't care, as long as copying the make flags and everything to an override won't brake anything (and it shouldn't) feel free @teto to run the script and add an override in |
teto
force-pushed
the
lua_for_sile
branch
3 times, most recently
from
e12748f
to
27c88c5
Compare
vstruct rockspec doesnt contain a license, which made luarocks-nix crash. Bump luarocks nix to fix this.
Not only the binary `parallel` displays a re,inder to quote their software but it systematically breaks update here regardless of my network quality. Better be slow than fail. If anyone can fix it, we may rollback this.
|
@doronbehar You don't have to submit all generated-packages.nix modifications. With If you don't beat me to it, I will prepare sthg next week. |
What do you mean by "beat me to it" and "sthg"? I noticed you still didn't merge here the pulseaudio and perhaps other updates to lua's generated package set right? |
Lua for sile (cherry picked from commit 29b5473)
Motivation for this change
add missing packages for #77738
@doronbehar while regenerating the set, I noticed pulseaudio was generated. Maybe you could move you changes to lua-pulseaudio in pkgs/development/lua-modules/overrides.nix instead.
@Shados I've disabled parallel, I have never been able to complete a single update with a value != 1.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)