Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.llfuse: darwin support, use in borgbackup #78429

Merged
merged 2 commits into from Jan 25, 2020
Merged

pythonPackages.llfuse: darwin support, use in borgbackup #78429

merged 2 commits into from Jan 25, 2020

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Enabling borg mount on macOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 24, 2020
@thefloweringash thefloweringash changed the title llfuse: darwin support, use in borgbackup pythonPackages.llfuse: darwin support, use in borgbackup Jan 24, 2020
@thefloweringash
Copy link
Member Author

@GrahamcOfBorg build borgbackup python2Packages.llfuse python3Packages.llfuse

@ofborg ofborg bot requested a review from bjornfor January 24, 2020 19:36
@ofborg ofborg bot requested a review from flokli January 25, 2020 04:17
@LnL7 LnL7 merged commit 6e6c16f into NixOS:master Jan 25, 2020
@thefloweringash thefloweringash deleted the llfuse-darwin branch January 26, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

@bjornfor bjornfor Awaiting requested review from bjornfor

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thefloweringash @bjornfor @flokli @LnL7