Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mindustry,mindustry-server: make it possible to choose what to build (server and/or client) #78558

Merged
1 commit merged into from Jan 30, 2020
Merged

mindustry,mindustry-server: make it possible to choose what to build (server and/or client) #78558

1 commit merged into from Jan 30, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 26, 2020

Motivation for this change

So that headless servers do not need to pull in the pulseaudio
dependency
As suggested by @petabyteboy here: #72306 (review)
With this commit, nixpkgs.mindustry-server builds only the server and nixpkgs.mindustry builds both the client and the server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
mindustry,mindustry-server: make it possible to choose what to build
d07761b 
So that headless servers do not need to pull in the pulseaudio
dependency
ghost
ghost approved these changes Jan 30, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is what I was looking for.
Built on NixOS x86_64 and tested basic functionality.

@ghost ghost merged commit 770756e into NixOS:master Jan 30, 2020
@fgaz fgaz mentioned this pull request Feb 4, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fgaz