Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #78481 from Infinisil/mumble-celt #78481

Merged
merged 2 commits into from Jan 26, 2020
Merged

Merge pull request #78481 from Infinisil/mumble-celt #78481

merged 2 commits into from Jan 26, 2020

Conversation

infinisil
Copy link
Member

Motivation for this change

Without this change you'll get an error like

Unable to find matching CELT codecs with other clients. You will not be able to talk to all users.

because libcelt can't be found. This seems to be due to the PLUGIN_PATH definition not applying correctly. It seems to work correctly with this change.

Ping @petabyteboy @greizgh @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from a user January 25, 2020 21:12
ghost
ghost reviewed Jan 26, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks fine to me.
Built and tested on NixOS x86_64 with sandboxing.

@infinisil infinisil changed the title mumble: Fix PLUGIN_PATH definition so it can find the CELT library Merge pull request #78481 from Infinisil/mumble-celt Jan 26, 2020
@infinisil infinisil merged commit 3c5add9 into NixOS:master Jan 26, 2020
@infinisil infinisil deleted the mumble-celt branch January 26, 2020 14:55
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 26, 2020
@infinisil @dtzWill
Merge pull request NixOS#78481 from Infinisil/mumble-celt
e131ec8 
mumble: Fix PLUGIN_PATH definition so it can find the CELT library
(cherry picked from commit 3c5add9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@infinisil