Skip to content

bitcoin: fix build on darwin #78454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2020
Merged

bitcoin: fix build on darwin #78454

merged 1 commit into from
Jan 25, 2020
+3 −3

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 25, 2020

Motivation for this change

Closes #76986
cc: @wereHamster

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@marsam
bitcoin: fix build on darwin

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
d47671b
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Jan 25, 2020
@ofborg ofborg bot requested review from roconnor and AndersonTorres January 25, 2020 08:39
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 25, 2020
@marsam marsam merged commit 03af480 into NixOS:master Jan 25, 2020
@marsam marsam deleted the fix-bitcoind-darwin branch January 25, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roconnor roconnor

@AndersonTorres AndersonTorres

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bitcoind fails to build on macOS
1 participant
@marsam