lutris: fix gog integration #78439
Merged
lutris: fix gog integration #78439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
approved these changes
Feb 23, 2020
|
I just tested this, and it works as expected. I'd like to see this merged :) @samlich could you rebase? |
Valodim
approved these changes
Apr 16, 2020
|
Hello, I would also know if this will be merged, maybe it was forgotten or something ? |
|
@samlich Thanks for the rebase! I was able to successfully download and install a GOG game with this patch. Would like to see this merged 👍 |
|
Any backport required? |
I believe so, I think I talked to @aanderse and it was broken on stable. |
|
@worldofpeace correct, I tried this recently and had the same error as reported in #65416. |
10 tasks
|
Hello, I can confirm that this PR fixed the issue for me on NixOS using nixos-unstable channel. I'm not using a DE, only AwesomeWM. If you need more details, just check my NixOS config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
closes #65416
Things done
Added
glib-networkingMoved
wrapGAppsHookfrombuildInputstonativeBuildInputs(this is why it wouldn't be properly wrapped before)Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)6_262_376_376 -> 6_262_378_904
Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.