Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnscrypt-proxy2: 2.0.25 -> 2.0.36 #78473

Merged
merged 1 commit into from Jan 25, 2020
Merged

dnscrypt-proxy2: 2.0.25 -> 2.0.36 #78473

merged 1 commit into from Jan 25, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 25, 2020 •
edited

Motivation for this change

https://github.com/DNSCrypt/dnscrypt-proxy/releases/tag/2.0.36

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ehmry January 25, 2020 16:35
@ehmry ehmry merged commit ad3f0d9 into NixOS:master Jan 25, 2020
@Atemu
Copy link
Member Author

Atemu commented Jan 25, 2020

Thanks @ehmry!

This is my first time contributing a version bump to nixpkgs, what needs to happen in order for this change to also be merged into the stable branch?

@ehmry
Copy link
Contributor

ehmry commented Jan 25, 2020

I believe you will have to wait until the next release, unless you can justify backporting this commit to 19.09.

@Atemu
Copy link
Member Author

Atemu commented Jan 26, 2020

This one probably can't be but out of curiosity, what could justify a commit being backported?

@ehmry
Copy link
Contributor

ehmry commented Jan 27, 2020

Security fixes, but I'm not familiar with the backporting procedure.

@Atemu
Copy link
Member Author

Atemu commented Jan 27, 2020

Thanks!

Where can I read up on the backporting procedure?

@Atemu Atemu deleted the dnscrypt-proxy2-2.0.36 branch July 30, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atemu @ehmry