Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amdgpu-fan: init at 0.0.6 #78474

Closed
wants to merge 2 commits into from
Closed

amdgpu-fan: init at 0.0.6 #78474

wants to merge 2 commits into from

Conversation

GRBurst
Copy link
Contributor

@GRBurst GRBurst commented Jan 25, 2020

Motivation for this change

This is a small tool / service in order to control the amdgpu fan. Currently, I am using it on a local branch. I did not test everything extensively but I am running it without any issues for a while now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I would split this into two commits:

pythonPackages.amdgpu-fan: init at 0.0.6
nixos/amdgpu-fan: init

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@GRBurst
Copy link
Contributor Author

GRBurst commented Feb 27, 2020

@GrahamcOfBorg build amdgpu-fan

@jonringer
Copy link
Contributor

package LGTM

@infinisil can you quickly look at the nixos module, I trust you more than me

enable = mkEnableOption "Python daemon for controlling the fans on amdgpu cards";

speed_matrix = mkOption {
type = types.lines;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more appropriate type would be better, e.g. uniq (listOf (listOf float)) (or are only ints possible?). Then you can set these with

{
  speedMatrix = [ [0 0] [40 30] [60 50] [80 100] ];
}

You'll have to write a small generator function for converting this to strings though.

options.services.amdgpu-fan = {
enable = mkEnableOption "Python daemon for controlling the fans on amdgpu cards";

speed_matrix = mkOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use camelCase, so speedMatrix instead

- [60, 100]
'';
description = ''
Define fan speed for different temperatures using a speed matrix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is a bit messed up, indent only 2 spaces after a ''

};

cards = mkOption {
type = types.lines;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also use a more appropriate type here, listOf str would fit here

'';
description = ''
Define cards that can be controlled. This can be any card returned from:
`ls /sys/class/drm | grep "^card[[:digit:]]$"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use <command>ls ...</command> to describe commands. This is Docbook, not Markdown


config = mkIf cfg.enable {

environment.systemPackages = [ pkg ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed in systemPackages? If you don't need the binary or something else from the package this shouldn't be needed.

wantedBy = [ "default.target" ];
serviceConfig = {
ExecStart = "${pkg}/bin/amdgpu-fan";
Restart = "always";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently runs as root. This should be avoided if possible. Try setting serviceConfig.DynamicUser = true to see if that works, or try to make if work if it doesn't (you might need to adjust some systemd settings, see man systemd.exec)


systemd.services.amdgpu-fan = {
description = "amdgpu fan controller";
wantedBy = [ "default.target" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if default.target really works, did you test this? Does it start the service on bootup and nixos-rebuild switches?

@stale
Copy link

stale bot commented Sep 2, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 2, 2020
@jonringer
Copy link
Contributor

I'm closing this PR due to lack of activity, if the PR author would like to pursue this matter again, please re-open the PR and address the concerns.

@jonringer jonringer closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants