amdgpu-fan: init at 0.0.6 #78474
amdgpu-fan: init at 0.0.6 #78474
Conversation
ofborg
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
GRBurst
force-pushed
the
amdgpu-fan
branch
2 times, most recently
from
711244d to
18f1524
Compare
|
@GrahamcOfBorg build amdgpu-fan |
ofborg
bot
added
11.by: package-maintainer
|
package LGTM @infinisil can you quickly look at the nixos module, I trust you more than me |
| enable = mkEnableOption "Python daemon for controlling the fans on amdgpu cards"; | ||
|
|
||
| speed_matrix = mkOption { | ||
| type = types.lines; |
There was a problem hiding this comment.
A more appropriate type would be better, e.g. uniq (listOf (listOf float)) (or are only ints possible?). Then you can set these with
{
speedMatrix = [ [0 0] [40 30] [60 50] [80 100] ];
}You'll have to write a small generator function for converting this to strings though.
| options.services.amdgpu-fan = { | ||
| enable = mkEnableOption "Python daemon for controlling the fans on amdgpu cards"; | ||
|
|
||
| speed_matrix = mkOption { |
There was a problem hiding this comment.
Use camelCase, so speedMatrix instead
| - [60, 100] | ||
| ''; | ||
| description = '' | ||
| Define fan speed for different temperatures using a speed matrix |
There was a problem hiding this comment.
Indentation is a bit messed up, indent only 2 spaces after a ''
| }; | ||
|
|
||
| cards = mkOption { | ||
| type = types.lines; |
There was a problem hiding this comment.
Should also use a more appropriate type here, listOf str would fit here
| ''; | ||
| description = '' | ||
| Define cards that can be controlled. This can be any card returned from: | ||
| `ls /sys/class/drm | grep "^card[[:digit:]]$"` |
There was a problem hiding this comment.
Use <command>ls ...</command> to describe commands. This is Docbook, not Markdown
|
|
||
| config = mkIf cfg.enable { | ||
|
|
||
| environment.systemPackages = [ pkg ]; |
There was a problem hiding this comment.
Is this needed in systemPackages? If you don't need the binary or something else from the package this shouldn't be needed.
| wantedBy = [ "default.target" ]; | ||
| serviceConfig = { | ||
| ExecStart = "${pkg}/bin/amdgpu-fan"; | ||
| Restart = "always"; |
There was a problem hiding this comment.
This currently runs as root. This should be avoided if possible. Try setting serviceConfig.DynamicUser = true to see if that works, or try to make if work if it doesn't (you might need to adjust some systemd settings, see man systemd.exec)
|
|
||
| systemd.services.amdgpu-fan = { | ||
| description = "amdgpu fan controller"; | ||
| wantedBy = [ "default.target" ]; |
There was a problem hiding this comment.
I'm not sure if default.target really works, did you test this? Does it start the service on bootup and nixos-rebuild switches?
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
I'm closing this PR due to lack of activity, if the PR author would like to pursue this matter again, please re-open the PR and address the concerns. |
Motivation for this change
This is a small tool / service in order to control the amdgpu fan. Currently, I am using it on a local branch. I did not test everything extensively but I am running it without any issues for a while now.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)