Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pretty-simple: init at 3.2.1.0 #78540

Merged
merged 1 commit into from Jan 29, 2020
Merged

pretty-simple: init at 3.2.1.0 #78540

merged 1 commit into from Jan 29, 2020

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Jan 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srghma srghma force-pushed the pretty-simple branch 2 times, most recently from b83c8da to b714ca5 Compare January 28, 2020 08:40
@ofborg ofborg bot removed the 6.topic: haskell label Jan 28, 2020
@cdepillabout cdepillabout merged commit c2eb1e9 into NixOS:master Jan 29, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@cdepillabout @anna328p
Merge pull request NixOS#78540 from srghma/pretty-simple
dac2646 
pretty-simple: init at 3.2.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srghma @cdepillabout