Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator-sdk: init at 0.18.2 #78451

Merged
merged 2 commits into from Jul 7, 2020
Merged

operator-sdk: init at 0.18.2 #78451

merged 2 commits into from Jul 7, 2020

Conversation

arnarg
Copy link
Contributor

@arnarg arnarg commented Jan 25, 2020

Motivation for this change

Operator-sdk is a cli tool for scaffolding and building Kubernetes operators. This tool is missing in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit January 25, 2020 02:42
doronbehar
doronbehar requested changes May 22, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit messages should be

maintainers: add arnarg
operator-sdk: init at 0.15.0

pkgs/development/tools/operator-sdk/default.nix Outdated Show resolved Hide resolved
@arnarg arnarg changed the title operator-sdk: init at 0.15.0 operator-sdk: init at 0.17.1 May 22, 2020
@arnarg
Copy link
Contributor Author

arnarg commented May 22, 2020

@doronbehar I rebased the commits to change the message. I also updated this to the most recent version as this PR is rather old.

@arnarg arnarg requested a review from doronbehar May 24, 2020 10:56
doronbehar
doronbehar approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and --help test.

@doronbehar
Copy link
Contributor

doronbehar commented May 24, 2020 •
edited

BTW @arnarg, this shouldn't block this PR, but you might wanna make sure your GitHub account has linked the email address you use for Git commits (see https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address) - this way, it'll be easy to see get to your profile if someone browses commits via the web interface. Right now Github writes:

Arnar Gauti Ingason authored and arnarg

@arnarg
Copy link
Contributor Author

arnarg commented May 25, 2020

@doronbehar I most likely made these commits using my old work email which I recently removed from my GitHub profile. I can rebase the commits again.

@blaggacao
Copy link
Contributor

blaggacao commented Jul 6, 2020 •
edited

Is anything blocking this PR? I'd very much use this in a nix shell...
@arnarg you might try commenting with /marvin opt-in

blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Jul 6, 2020
chore: add operator-sdk to nix-shell (commented)
5b5f179 
uncomment once merged: NixOS/nixpkgs#78451
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Jul 6, 2020
chore: add operator-sdk to nix-shell (commented)
5307547 
uncomment once merged: NixOS/nixpkgs#78451
@arnarg
Copy link
Contributor Author

arnarg commented Jul 7, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 7, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 7, 2020
@arnarg
Copy link
Contributor Author

arnarg commented Jul 7, 2020

/status needs_reviewer

@blaggacao
Copy link
Contributor

Result of nixpkgs-review pr 78451 1

1 package built:
- operator-sdk

Manually:

  • ./results/operator-sdk/bin/.operator-sdk-wrapped --help ok
  • grep WARN logs/operator-sdk.log empty
  • grep ERR logs/operator-sdk.log empty

@blaggacao
Copy link
Contributor

/status needs_merger

@timokau
Copy link
Member

timokau commented Jul 7, 2020

Bot mistake.
/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau July 7, 2020 21:32
@timokau
Copy link
Member

timokau commented Jul 7, 2020

Thanks for the reviews @doronbehar @blaggacao. Looks good to me.

Welcome to the team @arnarg!

@timokau timokau merged commit c6e47d5 into NixOS:master Jul 7, 2020
@arnarg arnarg deleted the adding-operator-sdk branch July 7, 2020 21:44
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Jul 7, 2020
chore: unlock operator-sdk
efc7d3b 
since merge of NixOS/nixpkgs#78451
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Jul 7, 2020
chore: add operator-sdk to nix-shell (commented)
9cb928c 
uncomment once merged: NixOS/nixpkgs#78451
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Jul 7, 2020
chore: unlock operator-sdk
296fafc 
since merge of NixOS/nixpkgs#78451
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Aug 18, 2020
chore: add operator-sdk to nix-shell (commented)
cb07bab 
uncomment once merged: NixOS/nixpkgs#78451
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Aug 18, 2020
chore: unlock operator-sdk
768b9c3 
since merge of NixOS/nixpkgs#78451
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Aug 18, 2020
chore: add operator-sdk to nix-shell (commented)
1a508c7 
uncomment once merged: NixOS/nixpkgs#78451
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Aug 18, 2020
chore: unlock operator-sdk
3d923d2 
since merge of NixOS/nixpkgs#78451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@blaggacao blaggacao blaggacao approved these changes

@doronbehar doronbehar doronbehar approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arnarg @doronbehar @blaggacao @timokau @sikmir