Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird, thunderbird-bin: 68.4.1 -> 68.4.2 #78452

Merged
merged 2 commits into from Jan 25, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 25, 2020

Motivation for this change
  • Various security fixes
  • Other fixes and changes.

https://www.thunderbird.net/en-US/thunderbird/68.4.2/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jan 25, 2020

The security part is weird. It's linked from the official page but the target page lists nothing for this release.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work OK for me.

vcunat added a commit that referenced this pull request Jan 25, 2020
@vcunat vcunat merged commit a5c3e06 into NixOS:master Jan 25, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 25, 2020
vcunat added a commit that referenced this pull request Jan 26, 2020
(cherry picked from commit b200b6b)
Re-tested both on 19.09.
@vcunat
Copy link
Member

vcunat commented Jan 27, 2020

I had backported it to stable but later it turned out that no security fixes were present in this bump.

@vcunat vcunat changed the title thunderbird, thunderbird-bin: 68.4.1 -> 68.4.2 [Security fixes] thunderbird, thunderbird-bin: 68.4.1 -> 68.4.2 Jan 27, 2020
@taku0
Copy link
Contributor Author

taku0 commented Jan 27, 2020

The early version of the release notes mentioned “Various security fixes”, but corresponding Security Advisories did not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants