Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft-server: 1.14.4 -> 1.15.2 #78514

Merged
merged 1 commit into from Jan 28, 2020
Merged

minecraft-server: 1.14.4 -> 1.15.2 #78514

merged 1 commit into from Jan 28, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jan 26, 2020 •
edited

Motivation for this change

Switch to the latest version of minecraft-server: https://www.minecraft.net/en-us/download/server/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

tomberek
tomberek reviewed Jan 26, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the “nix-prefetch-url” in the url field a copy paste error or a feature I’m not aware of?

@Frostman
Copy link
Member Author

@tomberek yeah, that's a copy-paste... Strange thing is that it works fine for me as I'm using it already. Pushed fixed commit.

@tomberek
Copy link
Contributor

The builder for fetchurl does some parsing and splitting. Perhaps the first word got dropped somehow. Might be worth investigating.

tomberek
tomberek approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs.

@ofborg ofborg bot requested a review from tomberek January 26, 2020 17:48
@benley benley merged commit e328078 into NixOS:master Jan 28, 2020
@Frostman Frostman deleted the minecraft-server-1.15.2 branch January 28, 2020 09:24
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 28, 2020
@Frostman @dtzWill
minecraft-server: 1.14.4 -> 1.15.2 (NixOS#78514)
859f5f1 
(cherry picked from commit e328078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @tomberek @benley