Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pymol: 2.1.0 -> 2.3.0 #78437

Merged
merged 5 commits into from Jan 25, 2020
Merged

pymol: 2.1.0 -> 2.3.0 #78437

merged 5 commits into from Jan 25, 2020

Conversation

samlich
Copy link
Contributor

@samlich samlich commented Jan 24, 2020 •
edited

Motivation for this change

Pymol was broken.

Things done
  • Fixed build and updated to 2.3.0 which is now hosted on GitHub.
  • Added myself as a maintainer as it had none.
  • Linked the desktop icon.

I have not fixed Qt support but plan to do so and add at least VMD sometime soon.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    (failed with pkgs/development/libraries/blitz: No such file or directory, which doesn't seem related)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    (didn't build before)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa merged commit a30a49c into NixOS:master Jan 25, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 26, 2020
@markuskowa @dtzWill
Merge pull request NixOS#78437 from samlich/pymol
4711221 
pymol: 2.1.0 -> 2.3.0
(cherry picked from commit a30a49c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samlich @markuskowa