Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: d7f2bf70bd35
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5e4c49463607
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jan 24, 2020

  1. execline: wrap unconditionally; strip 

    I don't think there's any situation in which an unwrapped execlineb is
useful -- if you want to use different versions of the execlineb tool
it'll still prefer ones in PATH.  At the same time, implementing the
wrapper in this way, as a series of two derivations, meant that we
didn't get stdenv goodness for the wrapper.  This meant that, for
example, the wrapper was not stripped, and so execline ended up with
runtime dependencies on gcc and the Linux headers.  I don't want to
have to reimplement this sort of stuff when it's already in stdenv,
and so it makes much more sense to create the wrapper in the
mkDerivation call, where all of stdenv's normal magic will find it.
    @alyssais @Profpatsch
    alyssais authored and Profpatsch committed Jan 24, 2020
    Copy the full SHA
    5e4c494 View commit details
    Browse the repository at this point in the history