Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foxtrotgps #78436

Merged
merged 2 commits into from Jan 27, 2020
Merged

foxtrotgps #78436

merged 2 commits into from Jan 27, 2020

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Jan 24, 2020 •
edited

Motivation for this change

Replacing the a long time ago abandoned tangogps by a recent foxtrotgps

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wucke13
tangogps: drop at 0.99.2
9a88d22 
tangogps is abandoned. It looks like it this is the case since the early
2010s. foxtrotgps is a fork, that still is maintained.
@wucke13 wucke13 changed the title [WIP] Foxtrotgps foxtrotgps Jan 24, 2020
@markuskowa
Copy link
Member

An entry in pkgs/top-level/aliases.nix would be nice.

@wucke13
Copy link
Contributor Author

wucke13 commented Jan 26, 2020 •
edited

@markuskowa Sure!

@markuskowa
Copy link
Member

@GrahamcOfBorg build foxtrotgps

@markuskowa markuskowa merged commit 67a71b6 into NixOS:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wucke13 @markuskowa