Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qpaeq: init at 13.0 #76321

Merged
merged 2 commits into from Jan 24, 2020
Merged

qpaeq: init at 13.0 #76321

merged 2 commits into from Jan 24, 2020

Conversation

mkg20001
Copy link
Member

Motivation for this change

Fixing the binary

See #8384

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323

@mkg20001 mkg20001 mentioned this pull request Dec 23, 2019
Closed
@mkg20001
Copy link
Member Author

#8384 (comment)

@ofborg ofborg bot requested a review from lovek323 December 23, 2019 22:28
matthiasbeyer
matthiasbeyer requested changes Dec 24, 2019
View reviewed changes
pkgs/servers/pulseaudio/qpaeq.nix Outdated Show resolved Hide resolved
pkgs/servers/pulseaudio/qpaeq.nix Outdated Show resolved Hide resolved
pkgs/servers/pulseaudio/qpaeq.nix Outdated Show resolved Hide resolved
@mkg20001 mkg20001 force-pushed the pkg/qpaeq branch 2 times, most recently from 352d32d to b706af9 Compare December 26, 2019 05:43
mkg20001
mkg20001 commented Dec 26, 2019
View reviewed changes
Copy link
Member Author

@mkg20001 mkg20001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ready now

@jtojnar
Copy link
Contributor

jtojnar commented Dec 26, 2019

Maybe we should suggest upstream to move qpaeq to a separate project/repo. Also https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/260

@mkg20001
Copy link
Member Author

Dunno. For now it seems like fixing the binary is a step in the right direction.

Adding the desktop file, how can that be done properly?

@mkg20001 mkg20001 force-pushed the pkg/qpaeq branch 2 times, most recently from 4b28161 to 7e3d978 Compare December 27, 2019 03:41
@mkg20001
Copy link
Member Author

Added desktop, removed unnecessary patch. Let's get this merged ^^

@mkg20001 mkg20001 force-pushed the pkg/qpaeq branch 2 times, most recently from b6d4664 to cdea6e6 Compare December 27, 2019 03:51
@mkg20001 mkg20001 changed the title qpaeq: init at unknown qpaeq: init at 13.0 Dec 29, 2019
@mkg20001 mkg20001 force-pushed the pkg/qpaeq branch 4 times, most recently from 9301330 to f0f4f64 Compare December 31, 2019 00:02
@mkg20001
Copy link
Member Author

It seems the build failures are all releated to the staging branch itself

Fixed the collision, don't see anything more to do.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 31, 2019

@GrahamcOfBorg eval

@FRidh FRidh added this to WIP in Staging via automation Dec 31, 2019
@FRidh FRidh moved this from WIP to Needs review in Staging Dec 31, 2019
@mkg20001
Copy link
Member Author

aarch64 fails with

  0     0    0     0    0     0      0      0 --:--:--  0:00:31 --:--:--     0
curl: (28) Failed to connect to www.freedesktop.org port 443: Connection timed out
error: cannot download libinput-1.15.0.tar.xz from any mirror

looks like it's just a network error, should work after restart

@worldofpeace worldofpeace merged commit bd1fbe5 into NixOS:staging Jan 24, 2020
Staging automation moved this from Needs review to Done Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

@jtojnar jtojnar jtojnar left review comments

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkg20001 @jtojnar @Mic92 @matthiasbeyer @worldofpeace