Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubstaff: 1.5.2 -> 1.5.7 #78532

Merged
merged 1 commit into from Dec 30, 2020
Merged

hubstaff: 1.5.2 -> 1.5.7 #78532

merged 1 commit into from Dec 30, 2020

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Jan 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek
Copy link
Contributor

tomberek commented Sep 7, 2020

Result of nixpkgs-review pr 78532 1

1 package built:
- hubstaff

tomberek
tomberek approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs on NixOS. Did not test funciton (no account).

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 78532 1

1 package built:
  • hubstaff

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/312

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 78532 run on x86_64-linux 1

1 package built:
  • hubstaff

@SuperSandro2000 SuperSandro2000 merged commit d9cb058 into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@srghma @tomberek @thiagokokada @nixos-discourse @SuperSandro2000