Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for nightlies is empty #7960

Closed
TrueBrain opened this issue Jan 25, 2020 · 1 comment
Closed

Changelog for nightlies is empty #7960

TrueBrain opened this issue Jan 25, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TrueBrain
Copy link
Member

Version of OpenTTD

n/a

Expected result

A changelog of the last 7 days

Actual result

Empty file

Steps to reproduce

https://www.openttd.org/downloads/openttd-nightlies/latest.html
Click "Changelog"
an empty file is presented

This is true for almost a year. The problem seems to be here:
https://github.com/OpenTTD/OpenTTD/blob/master/azure-pipelines/changelog.sh#L3

This is always true, so it thinks it is always a tag, and that logic there doesn't work on a non-tag. In result, the changelog is empty.
@James103
Copy link
Contributor

A workaround would be to go into the GitHub commit history to view the changes, but some people may not want to go to Github just to see the changelog, which means this is still a bug that could be fixed.

@TrueBrain TrueBrain added bug Something isn't working good first issue Good for newcomers labels Jan 25, 2020
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 25, 2020
@glx22
Fix OpenTTD#7960: use the same method as findversion.sh to determine tag
7084347
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@glx22 @douiwby
Fix OpenTTD#7960: use the same method as findversion.sh to determine tag
fc5f3c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @James103