New package : fluxboxlauncher #78492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/creation-de-mon-premier-paquet-nix/5538/15 |
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1-10
labels
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
from
901a600
to
65782b9
Compare
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
2 times, most recently
from
fb799f9
to
f32938d
Compare
|
The commit message should be: I tested the build which works ok, but there is some missing runtime dependencies. When I click on 'search an application': |
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
from
f32938d
to
41ed893
Compare
|
@eonpatapon : I've replace rox by GtkAppChooserDialog, update fluxboxlauncher at 0.2.1 and changed commit title. |
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
from
41ed893
to
008b47c
Compare
|
Seems forgot to update the `sha256`:
```
hash mismatch in fixed-output derivation '/nix/store/34p534ifdq236qmmgs3c1dgvn2bj3ila-source':
wanted: sha256:196k2lv03has2q5sr2bxxdnlyyvr8sr9hvn9az2x73n83mbmc7qb
got: sha256:024h1dk0bhc5s4dldr6pqabrgcqih9p8cys5lqgkgz406y4vyzvf
```
|
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
from
008b47c
to
b4de5b3
Compare
|
@eonpatapon : right, done. |
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
from
b4de5b3
to
8173f63
Compare
|
LGTM |
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
from
8173f63
to
63f011c
Compare
mothsART
force-pushed
the
feature/new-package-fluxboxlauncher
branch
from
63f011c
to
d37dbd7
Compare
infinisil
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)