Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package : fluxboxlauncher #78492

Merged
merged 1 commit into from
Mar 6, 2020
Merged

New package : fluxboxlauncher #78492

merged 1 commit into from
Mar 6, 2020
+58 −0

Conversation

mothsART
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/creation-de-mon-premier-paquet-nix/5538/15

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Jan 27, 2020
@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch from 901a600 to 65782b9 Compare January 27, 2020 22:22
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 27, 2020
@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch 2 times, most recently from fb799f9 to f32938d Compare January 28, 2020 18:38
@mothsART mothsART requested a review from infinisil January 28, 2020 18:39
@eonpatapon
Copy link
Contributor

The commit message should be: fluxboxlauncher: init at 0.2

I tested the build which works ok, but there is some missing runtime dependencies. When I click on 'search an application':

sh: rox: command not found

@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch from f32938d to 41ed893 Compare February 6, 2020 19:54
@mothsART
Copy link
Contributor Author

mothsART commented Feb 6, 2020

@eonpatapon : I've replace rox by GtkAppChooserDialog, update fluxboxlauncher at 0.2.1 and changed commit title.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 6, 2020
@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch from 41ed893 to 008b47c Compare February 6, 2020 20:55
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 6, 2020
@eonpatapon
Copy link
Contributor

eonpatapon commented Feb 7, 2020 via email

@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch from 008b47c to b4de5b3 Compare February 7, 2020 18:47
@mothsART
Copy link
Contributor Author

mothsART commented Feb 7, 2020

@eonpatapon : right, done.

@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch from b4de5b3 to 8173f63 Compare February 7, 2020 19:07
@eonpatapon
Copy link
Contributor

LGTM

@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch from 8173f63 to 63f011c Compare February 14, 2020 18:25
@mothsART mothsART force-pushed the feature/new-package-fluxboxlauncher branch from 63f011c to d37dbd7 Compare March 4, 2020 18:23
@infinisil infinisil merged commit 3982db1 into NixOS:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mothsART @nixos-discourse @eonpatapon @infinisil