Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/networkd: add vrfConfig option for netdevs, add simple test #78476

Merged
merged 2 commits into from Jan 31, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 25, 2020

Motivation for this change

This PR consists of two changes:

  • add `vrfConfig` option to netdevs: This change adds the VRF.Table option to netdev units in networkd. Although this affects just one option, I figured that this might still be helpful e.g. for accessibility and to point users to further resources about VRFs from our manual.

  • add test for VRF configurations: This change adds a VM test which setups a small network where a VM communicates with other machines through a VRF. I decided to add this for two reasons:

    • As I didn't find too many resources about VRFs, I figured that this might be helpful for some people to get started (IMHO many VM-tests also serve as some kind of usage example).
    • On a Linux 5.4-kernel I had some issues with VRFs as it wasn't possible to SSH to an IP which is routed through the VRF. I think that such a test may help us to catch such regressions e.g. when updating the default kernel.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested review from flokli, andir and fpletz January 26, 2020 21:56
@andir andir mentioned this pull request Jan 28, 2020
10 tasks
@flokli flokli requested review from picnoir and removed request for flokli January 31, 2020 12:25
@andir andir merged commit 355b31c into NixOS:master Jan 31, 2020
@Ma27 Ma27 deleted the networkd-vrf-options branch January 31, 2020 12:31
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
nixos/networkd: add vrfConfig option for netdevs, add simple test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants