Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode vscodium backports [20.03] #84846

Merged
merged 10 commits into from Apr 12, 2020
Merged

vscode vscodium backports [20.03] #84846

merged 10 commits into from Apr 12, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I excluded commits that I thought would be problematic for a stable release.
So it's just updates and one bugfix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Synthetica9 and others added 10 commits April 9, 2020 16:26
@Synthetica9 @worldofpeace
vscodium: 1.41.1 -> 1.42.0
7514605 
(cherry picked from commit 603109c)
@Synthetica9 @worldofpeace
vscode, vscodium: 1.42.0 -> 1.42.1
95ca22a 
(cherry picked from commit 91a106d)
@domenkozar @worldofpeace
vscode: specify runtimeDependencies instead of LD_LIBRARY_PATH
35b1992 
This avoids glibc verions mismatches in vscode terminal, as
LD_LIBRARY_PATH leaks into terminal and break with user installed
executables.

(cherry picked from commit 40d7ce7)
@Synthetica9 @worldofpeace
vscode, vscodium: 1.42.1 -> 1.43.0
5c8fd2d 
(cherry picked from commit 9be5800)
@domenkozar @worldofpeace
vscode: fix build on darwin
d6209e5 
(cherry picked from commit be80721)
@worldofpeace
vscode: add backports notice
de5269a 
(cherry picked from commit c9fd76d)
@worldofpeace
vscodium: add backports notice
13d0920 
(cherry picked from commit f9fc1d3)
@eadwu @worldofpeace
vscode: 1.43.0 -> 1.43.2
829f656 
(cherry picked from commit a05f67e)
@eadwu @worldofpeace
vscodium: 1.43.0 -> 1.43.2
763a3b4 
(cherry picked from commit 3f75bc2)
@Synthetica9 @worldofpeace
vscode, vscodium: 1.43.2 -> 1.44.0
69f1529 
(cherry picked from commit 939041b)
@ofborg ofborg bot requested review from Synthetica9 and eadwu April 9, 2020 20:38
@worldofpeace worldofpeace merged commit 88661bf into NixOS:release-20.03 Apr 12, 2020
@worldofpeace worldofpeace deleted the backports-vscode-vscodium branch April 12, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @Synthetica9 @domenkozar @eadwu