cataclysmDDA: add modding interface #84873
Conversation
|
On Darwin, the launcher fails to find installed mods. The XDG launcher on Linux has the same problem. I'll try to fix it. |
|
Fixed the launcher problem. Confirmed that it builds and runs successfully on NixOS and Darwin. |
|
I didn't check all the nix files but it builds and runs fine for me. 👍 I also tested the launcher on NixOS with gnome and using the undead people tileset. Thank you very much for this PR. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
I tested this PR multiple times and it works perfectly. Can we merge this? |
|
ping @worldofpeace |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
There's one glaring issue with this PR, and it's the documentation. It's not a part of any user facing material like the nixpkgs manual. I believe that section would belong there because it's "how to configure a package". We luckily can include markdown into the nixpkgs manual, if it was the nixos one you'd have to translate it to docbook. I don't think our documentation on how to do this is sufficient however https://nixos.org/nixpkgs/manual/#chap-contributing (and I'm not sure how either). Perhaps asking how in #nixos-dev will help. |
|
My best guess is the trail left by the python framework: In the my intuition tells me pandoc converts the section into a file name like this? In that same directory, the actual file is named I'm not sure that will be helpful, but it's the best can intuit at the moment. |
|
@worldofpeace Many thanks for your help. I moved the document to nixpkgs manual. |
|
There is another version bump for the stable version: /pull/93349. I will rebase this PR after that has been merged. |
Each time src/translations.cpp is modified, we have to update the locale patch. Using sed to patch dynamically should be handy.
Add new namespace 'cataclysmDDA', in which package builders, games, and mods are listed.
Example:
let
customMods = self: super: lib.recursiveUpdate super {
soundpack.AwesomeSounds = cataclysmDDA.buildSoundPack { ... };
};
in
cataclysm-dda.withMods (mods: with mods.extend customMods; [
tileset.UndeadPeople
soundpack.AwesomeSounds
])
'cataclysm-dda-git.overrideAttrs (_: { version = ...; src = fetchFromGitHub { ... }; })'
did not update VERSION make flag correctly.
With this change, one can override 'cataclysm-dda-git' correctly and
more easily:
cataclysm-dda-git.override { version = ...; rev = ...; sha256 = ...; }
Add description about `useXdgDir` flag
globstar (**) does not work in Makefile
|
Rebase done. |
|
Hi @mnacamura, I just tried f2b2347 and got Any ideas? |
|
The documentation looks good though 👍 |
|
@svenkeidel Thanks for checking the document. I think |
|
🤦♂️ thanks. Sometimes the nix tooling can be confusing. |
|
Thank you @mnacamura |
Motivation for this change
This PR adds a basic interface to package Cataclysm DDA mods, soundpacks, and tilesets. See this and this comments. It also adds UndeadPeople tileset, which was dropped in the latest version bump.
Minor improvements:
cataclysm-dda-gitto be overidden correctlycataclysmdda{,-git}withUSE_XDG_DIRflagThis PR should be merged after /pull/84261.DONEThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)