Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pynwb: init at 1.3.0 #84857

Closed
wants to merge 2 commits into from
Closed

pythonPackages.pynwb: init at 1.3.0 #84857

wants to merge 2 commits into from

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented Apr 9, 2020

Motivation for this change

add package for working with Neurodata stored in the NWB format

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.


meta = with lib; {
description = "Package for working with Neurodata stored in the NWB format";
homepage = https://github.com/NeurodataWithoutBorders/pynwb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfc 45

Suggested change
homepage = https://github.com/NeurodataWithoutBorders/pynwb;
homepage = "https://github.com/NeurodataWithoutBorders/pynwb";


buildPythonPackage rec {
pname = "hdmf";
version = "1.6.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "1.6.1";
version = "1.6.1";
disabled = isPy27;
builder for '/nix/store/k531c83irjwjf533ind83a5fcw8m9ln1-python2.7-hdmf-1.6.1.drv' failed with exit code 1; last 10 log lines:
                           ^
  SyntaxError: invalid syntax


  ----------------------------------------------------------------------
  Ran 27 tests in 0.001s

  FAILED (errors=27)
  Test failed: <unittest.runner.TextTestResult run=27 errors=27 failures=0>
  error: Test failed: <unittest.runner.TextTestResult run=27 errors=27 failures=0>
cannot build derivation '/nix/store/4w0dg349mqg3wb61nigibzg7523i3zkz-python2.7-pynwb-1.3.0.drv': 1 dependencies couldn't be built

Comment on lines +11 to +13
buildPythonPackage rec {
pname = "pynwb";
version = "1.3.0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt seem to build'

builder for '/nix/store/rxb3ydcy00gfq2gzbm3ivddvhj1fv22z-python3.8-pynwb-1.3.0.drv' failed with exit code 1; last 10 log lines:

  - ('hdmf-common', 'core', 'B2BL0UA4UN', '2X3ZCGXIMI')
  + ('hdmf-common', 'core')

  ----------------------------------------------------------------------
  Ran 284 tests in 39.757s

  FAILED (failures=1)
  Test failed: <unittest.runner.TextTestResult run=284 errors=0 failures=1>
  error: Test failed: <unittest.runner.TextTestResult run=284 errors=0 failures=1>
builder for '/nix/store/pskzl4mvapjzy754v0armf0rk6a1nh30-python3.7-pynwb-1.3.0.drv' failed with exit code 1; last 10 log lines:

  - ('hdmf-common', 'core', 'YDGT6MVJ98', '5Q5HEGTMFJ')
  + ('hdmf-common', 'core')

  ----------------------------------------------------------------------
  Ran 284 tests in 45.498s

  FAILED (failures=1)
  Test failed: <unittest.runner.TextTestResult run=284 errors=0 failures=1>
  error: Test failed: <unittest.runner.TextTestResult run=284 errors=0 failures=1>
cannot build derivation '/nix/store/qr9p8dxialvry4ipi2aqb37104palxnl-env.drv': 4 dependencies couldn't be built
[4 built (3 failed), 4 copied (1.4 MiB), 0.3 MiB DL]
error: build of '/nix/store/qr9p8dxialvry4ipi2aqb37104palxnl-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/84857
4 package failed to build:
python27Packages.hdmf python27Packages.pynwb python37Packages.pynwb python38Packages.pynwb

@jonringer jonringer marked this pull request as draft April 10, 2020 19:46
@stale
Copy link

stale bot commented Jun 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 9, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants