Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerdfonts: make it easier to configure and build #84858

Merged
merged 4 commits into from Apr 10, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Apr 9, 2020

Motivation for this change

It takes very long to install nerdfonts and it takes a lot of disk space considering most users' usage of only few specific fonts. With this change, a user can choose the fonts he wishes to install with:

nerdfonts.override {
  fonts = [
    "AnonymousPro"
    "Hack"
  ];
}

And only the necessary fonts will be downloaded and installed.

This should fix the build for macos and hence supersede #80690 (cc @uosis) .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/data/fonts/nerdfonts/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/nerdfonts/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/nerdfonts/create-shas.sh Outdated Show resolved Hide resolved
@Mic92 Mic92 merged commit 87d3217 into NixOS:master Apr 10, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Apr 10, 2020
nerdfonts: make it easier to configure and build
(cherry picked from commit 87d3217)
@doronbehar doronbehar mentioned this pull request May 2, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants