pythonPackages.HAP-python: init at 2.7.0 #84895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Apr 10, 2020
Comment on lines
18
to
33
| checkInputs = [ pytest ]; | ||
|
|
||
| #disable tests needing network | ||
| checkPhase = '' | ||
| pytest -k 'not test_persist \ | ||
| and not test_setup_endpoints \ | ||
| and not test_auto_add_aid_mac \ | ||
| and not test_service_callbacks \ | ||
| and not test_send_events \ | ||
| and not test_not_standalone_aid \ | ||
| and not test_start_stop_async_acc \ | ||
| and not test_start_stop_sync_acc' | ||
| ''; | ||
|
|
||
| propagatedBuildInputs = | ||
| [ curve25519-donna ed25519 cryptography ecdsa zeroconf ]; |
There was a problem hiding this comment.
typical ordering, also, if you have many items in a list, the current best practices should look like propagatedBuildInputs below
Suggested change
| checkInputs = [ pytest ]; | |
| #disable tests needing network | |
| checkPhase = '' | |
| pytest -k 'not test_persist \ | |
| and not test_setup_endpoints \ | |
| and not test_auto_add_aid_mac \ | |
| and not test_service_callbacks \ | |
| and not test_send_events \ | |
| and not test_not_standalone_aid \ | |
| and not test_start_stop_async_acc \ | |
| and not test_start_stop_sync_acc' | |
| ''; | |
| propagatedBuildInputs = | |
| [ curve25519-donna ed25519 cryptography ecdsa zeroconf ]; | |
| propagatedBuildInputs = [ | |
| curve25519-donna | |
| ed25519 | |
| cryptography | |
| ecdsa | |
| zeroconf | |
| ]; | |
| checkInputs = [ pytest ]; | |
| #disable tests needing network | |
| checkPhase = '' | |
| pytest -k 'not test_persist \ | |
| and not test_setup_endpoints \ | |
| and not test_auto_add_aid_mac \ | |
| and not test_service_callbacks \ | |
| and not test_send_events \ | |
| and not test_not_standalone_aid \ | |
| and not test_start_stop_async_acc \ | |
| and not test_start_stop_sync_acc' | |
| ''; | |
There was a problem hiding this comment.
Thanks for the quick review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Homekit connectivity for Home Assistant
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)