Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

croc: 8.0.5 -> 8.0.7 #84862

Merged
merged 1 commit into from Apr 10, 2020
Merged

croc: 8.0.5 -> 8.0.7 #84862

merged 1 commit into from Apr 10, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 9, 2020

https://github.com/schollz/croc/releases/tag/v8.0.6
https://github.com/schollz/croc/releases/tag/v8.0.7

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

equirosa
equirosa reviewed Apr 10, 2020
View reviewed changes
Copy link
Contributor

@equirosa equirosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update itself works fine; however, upon testing the transfer of a file I get the following:
securing channel...could not secure channel

Can anyone else check if this happens on their machines as well?

@HugoReeves
Copy link
Member

Builds on MacOS Catalina and NixOS.
Transfer from NixOS to MacOS worked but transfer from MacOS to NixOS failed multiple times. This may be a local issue and not a croc issue.
@equirosa I did receive the securing channel...could not secure channel error multiple times.
I may file a bug report in the croc repo.
Suggest we hold off merging.

@zowoq
Copy link
Contributor Author

zowoq commented Apr 10, 2020

I can't reproduce any issues.

Tested:
NixOS <-> NixOS
NixOS <-> macOS
macOS <-> macOS

@HugoReeves
Copy link
Member

Ok then, I'm assuming my issue is probably some local network issue. I won't file a bug report with croc.

@marsam marsam merged commit 4bf0ba4 into NixOS:master Apr 10, 2020
@zowoq zowoq deleted the croc branch April 10, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equirosa equirosa equirosa left review comments

@HugoReeves HugoReeves HugoReeves approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @HugoReeves @equirosa @marsam