Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redmine: 4.1.0 -> 4.1.1 #84823

Merged
merged 1 commit into from Apr 19, 2020
Merged

redmine: 4.1.0 -> 4.1.1 #84823

merged 1 commit into from Apr 19, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 9, 2020

Motivation for this change

https://www.redmine.org/projects/redmine/wiki/Changelog_4_1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 9, 2020
@aanderse
Copy link
Member Author

aanderse commented Apr 9, 2020 •
edited

@GrahamcOfBorg test redmine.mysql redmine.pgsql

aanderse
aanderse commented Apr 9, 2020
View reviewed changes
pkgs/applications/version-management/redmine/gemset.nix
@@ -124,6 +152,8 @@
};
capybara = {
dependencies = ["addressable" "mini_mime" "nokogiri" "rack" "rack-test" "regexp_parser" "xpath"];
groups = ["test"];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manveru up until this point I have been using bundix from NixOS 18.09 because bundix past that point added groups to gemset.nix. Mostly because I've been lazy I haven't dug into how to fix this...

I'll be forced to use a newer bundix now, as we discussed over IRC. This is a good thing... but I'm wondering if you have any insight into how I can fix the current error I'm getting here:

https://logs.nix.ci/?key=nixos/nixpkgs.84823&attempt_id=21b0f328-2508-4399-8376-b725c7c03c3c

machine# [   18.110780] flgad10fxwl3fxvcndgc5cd1x4f3iz6j-unit-script-redmine-pre-start[868]: Bundler::GemNotFound: Could not find capybara-3.25.0 in any of the sources

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to add test to the groups in the default.nix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manveru thanks for the simple and straight forward answer, though I'm left wondering why redmine is choking because of capybara when that is supposed to be a test only thing... 🤔

@aanderse
Copy link
Member Author

@GrahamcOfBorg test redmine.mysql
@GrahamcOfBorg test redmine.pgsql

@aanderse aanderse requested a review from manveru April 11, 2020 23:32
@aanderse aanderse mentioned this pull request Apr 12, 2020
Draft
10 tasks
@aanderse aanderse marked this pull request as ready for review April 15, 2020 17:19
@NixOS NixOS deleted a comment from nixos-discourse Apr 17, 2020
@pvgoran
Copy link
Contributor

pvgoran commented Apr 19, 2020

I tested this update, using an existing database from 19.09's Redmine 4.0.6. I had some troubles with updating the test system to the master branch, but the Redmine update itself worked well.

@aanderse
Copy link
Member Author

@pvgoran thanks for testing. Can you elaborate on the issues you had?

@pvgoran
Copy link
Contributor

pvgoran commented Apr 19, 2020

@aanderse Apart from a minor configuration issue (services.httpd.virtualHosts not accepting an array anymore) and a custom package compilation error (supposedly caused by some kind of GCC incompatibility which I didn't investigate yet), I faced a problem with ACME setup (#85534). None of this is relevant to Redmine, though.

@aanderse
Copy link
Member Author

@pvgoran thank you for reporting. It sounds like you're approving this PR then 🎉

@aanderse aanderse merged commit b3ae792 into NixOS:master Apr 19, 2020
@aanderse aanderse deleted the redmine-master branch April 19, 2020 19:51
@aanderse aanderse mentioned this pull request Apr 21, 2020
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @pvgoran @manveru @TredwellGit