gc.cc: Ignore hidden files in temproots #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Thanks! This also will fix cases where the nix store is stored in a NFS share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out Nix on Gentoo, I noticed that
nix-collect-garbagefailed, outputting simplyerror: stoi. Investigating a bit, I noticed that in/nix/var/nix/temproots, there was a file called.keep_sys-apps_nix-0, which Nix tried to interpret as a process ID (and failed, of course). Apparently, Gentoo puts such files in directories in order to remember if any package wants this directory there (even if might be currently empty). If the file's not there, Gentoo will delete the directory.Since creating the temproots directory dynamically seemed a bit "unsafe", I changed the GC code so that hidden files are ignored. I'm not sure myself if that's a good solution, to be honest. But it does improve interoperability with other package managers, apparently.