Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.{pyshark,pylxd,nsenter}: init #84793

Closed
wants to merge 4 commits into from
Closed

pythonPackages.{pyshark,pylxd,nsenter}: init #84793

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 9, 2020

Motivation for this change

This adds some general purpose python modules that I need to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from FRidh and jonringer as code owners April 9, 2020 09:52
jonringer
jonringer suggested changes Apr 9, 2020
View reviewed changes
pkgs/development/python-modules/argparse/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cherrypy/default.nix Outdated
Comment on lines 43 to 44

doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Author

@ghost ghost Apr 9, 2020 •
edited by ghost

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the failing tests were preventing me from building pylxd. I took a closer look now and found that it was only one test, so I deselected that. The breakage started with the python 3.7.6 -> 3.7.7 update. An update of the module did not help.

pkgs/development/python-modules/nsenter/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nsenter/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nsenter/default.nix Show resolved Hide resolved
pkgs/development/python-modules/nsenter/default.nix

buildPythonPackage rec {
pname = "nsenter";
version = "0.2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hasn't seen an update in 4 years, it probably shouldn't go in nixpkgs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been new changes to the repository as recently as 16 days ago and there is no hint that it is unmaintained. If you want I can also package the latest master revision, but there haven't been significant changes, mostly because it still works fine as it is.

pkgs/development/python-modules/nsenter/default.nix Outdated Show resolved Hide resolved
Milan Pässler added 2 commits April 10, 2020 00:00
python3Packages.cherrypy: 18.3.0 -> 18.5.0
a27547e 
The test `cherrypy/test/test_tools.py::ToolTests::testCombinedTools` is
failing since the python was updated to 3.7.7 and is now deselected.
pythonPackages.nsenter: init at 0.2.0
d70977d
@ghost
Copy link
Author

ghost commented Apr 9, 2020

I copy-pasted this from a private repo where I had packaged it a long time ago. I should have been more careful while doing that.

oxzi
oxzi reviewed May 15, 2020
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the pyshark package successfully. The other packages I have not tried, but they look okay at first sight.

@pstch
Copy link
Contributor

pstch commented May 25, 2020 •
edited

I have tested the pylxd package successfully (actually was ready to going this exact same derivation before realising this PR already existed...). You can add me as maintainer for it if you want.

@ghost ghost closed this Dec 11, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pstch @jonringer @oxzi @ryantm