Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jitsi-meet-electron: init at 2.0.0 #84898

Merged
merged 1 commit into from Apr 14, 2020
Merged

jitsi-meet-electron: init at 2.0.0 #84898

merged 1 commit into from Apr 14, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 10, 2020 •
edited

Motivation for this change

Fixes #84082

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Apr 10, 2020
Closed
@prusnak
Copy link
Member Author

prusnak commented Apr 10, 2020 •
edited

I tried to package $pname but I am stuck at the point where running the binary ends up with the following:

Error launching app
Unable to find Electron app at /nix/store/kr1wxwv7j8r0nz8vcy5lbzal1gapbw7f-jitsi-meet-electron-2.0.5/share/jitsi-meet-electron

Cannot find module '/nix/store/kr1wxwv7j8r0nz8vcy5lbzal1gapbw7f-jitsi-meet-electron-2.0.5/share/jitsi-meet-electron'
Require stack:
- /nix/store/3cbprqw7nvnp8imp8y5ih24d8x556vpn-electron-8.0.0/lib/electron/resources/default_app.asar/main.js
-

Maybe someone with more Electron experience can help me here?

The directory under ..../share/jitsi-meet-electron contains the following:

./resources/app.asar
./locales/*.pak

@worldofpeace
Copy link
Contributor

I tried to package $pname but I am stuck at the point where running the binary ends up with the following:

Error launching app
Unable to find Electron app at /nix/store/kr1wxwv7j8r0nz8vcy5lbzal1gapbw7f-jitsi-meet-electron-2.0.5/share/jitsi-meet-electron

Cannot find module '/nix/store/kr1wxwv7j8r0nz8vcy5lbzal1gapbw7f-jitsi-meet-electron-2.0.5/share/jitsi-meet-electron'
Require stack:
- /nix/store/3cbprqw7nvnp8imp8y5ih24d8x556vpn-electron-8.0.0/lib/electron/resources/default_app.asar/main.js
-

Maybe someone with more Electron experience can help me here?

The directory under ..../share/jitsi-meet-electron contains the following:

./resources/app.asar
./locales/*.pak

Your --add-flags in the wrapper needs to be directly to the asar archive file.

@prusnak prusnak force-pushed the jitsi-meet-electron branch 2 times, most recently from e84b4c0 to 7d5d725 Compare April 10, 2020 16:58
@prusnak prusnak changed the title jitsi-meet-electron: init at 2.0.5 jitsi-meet-electron: init at 2.0.0 Apr 10, 2020
@prusnak prusnak marked this pull request as ready for review April 10, 2020 17:00
@prusnak
Copy link
Member Author

prusnak commented Apr 10, 2020

I fixed the issues and the PR is ready for review.

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 10, 2020 •
edited

@prusnak Not wrapping in this app would make this package dependent on #84913 being fixed. I recommend just adding a todo and reference to the issue in code, and in the thread.

Edit: Sorry, I should make it clear that you actually should use wrapGAppsHook.

@prusnak
Copy link
Member Author

prusnak commented Apr 10, 2020

The package works for me as is without any problems.

If there is a need to wait for #84913 to be merged before this goes in, I am more than fine to wait.

@ghost
Copy link

ghost commented Apr 10, 2020 •
edited by ghost

Works fine for me, even in a nix-shell with --pure 👍

@worldofpeace
Copy link
Contributor

Likely your environments are polluted by wrapped programs. If it has any sort of file chooser it will likely crash without the gtk schema.

@prusnak
Copy link
Member Author

prusnak commented Apr 10, 2020

It seems there are not native dialogs in the app, that's why I was not able to cause a crash.

worldofpeace
worldofpeace approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving that this does work. In fact, I used it in the 20.03 GO/NO-GO meeting and have been using it since 😄

@worldofpeace worldofpeace merged commit c92a00c into NixOS:master Apr 14, 2020
@worldofpeace
Copy link
Contributor

Thanks @prusnak ✨

@prusnak prusnak deleted the jitsi-meet-electron branch April 14, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging Request: Jitsi Meet Electron
2 participants
@prusnak @worldofpeace