Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud: Review installation upgrade warning wording #84849

Merged
merged 1 commit into from Apr 11, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Apr 9, 2020

The new wording does not assume the user is upgrading.

This is because a user could be setting up a new installation on 20.03
on a server that has a 19.09 or before stateVersion!!

The new wording ensures that confusion is reduced by stating that they
do not have to care about the assumed 16→17 transition.

Then, the wording explains that they should, and how to upgrade to
version 18.

It also reviews the confusing wording about "multiple" upgrades.


The only thing we cannot really do is stop a fresh install of 17 if
there was no previous install, as it cannot be detected. That makes a
useless upgrade forced for new users with old state versions.

It is also important to state that they must set their package to
Nextcloud 18, as future upgrades to Nextcloud will not allow an uprade
from 17!

I assume future warning messages will exist specifically stating what to
do to go from 18 to 19, then 19 to 20, etc...


cc @Ma27 @worldofpeace

I don't think this is a blocker for 20.03, but something to apply ASAP to 20.03 once approved.

The new wording does not assume the user is upgrading.

This is because a user could be setting up a new installation on 20.03
on a server that has a 19.09 or before stateVersion!!

The new wording ensures that confusion is reduced by stating that they
do not have to care about the assumed 16→17 transition.

Then, the wording explains that they should, and how to upgrade to
version 18.

It also reviews the confusing wording about "multiple" upgrades.

* * *

The only thing we cannot really do is stop a fresh install of 17 if
there was no previous install, as it cannot be detected. That makes a
useless upgrade forced for new users with old state versions.

It is also important to state that they must set their package to
Nextcloud 18, as future upgrades to Nextcloud will not allow an uprade
from 17!

I assume future warning messages will exist specifically stating what to
do to go from 18 to 19, then 19 to 20, etc...
@samueldr samueldr requested a review from Ma27 April 9, 2020 20:58
@samueldr samueldr added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 9, 2020
@@ -322,12 +322,21 @@ in {
Please migrate your configuration to config.services.nextcloud.poolSettings.
'')
++ (optional (versionOlder cfg.package.version "18") ''
A legacy Nextcloud install (from before NixOS 20.03) may be installed.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the wording "legacy Nextcloud install" as it kinda says "legacy nextcloud", but it's "our old kind of setup". Any proposals?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An older version of Nextcloud?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm thinking here is that the fault lies in our setup of Nextcloud, not in Nextcloud being of an older version.

@Ma27
Copy link
Member

Ma27 commented Apr 10, 2020

The only thing we cannot really do is stop a fresh install of 17 if
there was no previous install, as it cannot be detected. That makes a
useless upgrade forced for new users with old state versions.

I'm pretty sure that this issue will reappear. What if Nextcloud 19 and 20 is available before 20.09? Then we'd have to take extra-care of folks being on Nextcloud 17.

Apart from that, this is "just" warning that doesn't keep you from deploying.

It is also important to state that they must set their package to
Nextcloud 18, as future upgrades to Nextcloud will not allow an uprade
from 17!

I think this is already done by noting that it's not possible to skip multiple major-versions when upgrading.

I assume future warning messages will exist specifically stating what to
do to go from 18 to 19, then 19 to 20, etc...

Yes. I even noted this in the manual btw :)

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads nicer.

@worldofpeace worldofpeace merged commit 15d5a2a into NixOS:master Apr 11, 2020
@samueldr samueldr deleted the fix/nextcloud-upgrade-wording branch April 11, 2020 03:10
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 11, 2020
@samueldr
Copy link
Member Author

Backported to 20.03

806ddfb...f3a3c96

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 11, 2020
@Ma27
Copy link
Member

Ma27 commented Apr 11, 2020

@samueldr great job, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants