nextcloud: Review installation upgrade warning wording #84849
Conversation
The new wording does not assume the user is upgrading. This is because a user could be setting up a new installation on 20.03 on a server that has a 19.09 or before stateVersion!! The new wording ensures that confusion is reduced by stating that they do not have to care about the assumed 16→17 transition. Then, the wording explains that they should, and how to upgrade to version 18. It also reviews the confusing wording about "multiple" upgrades. * * * The only thing we cannot really do is stop a fresh install of 17 if there was no previous install, as it cannot be detected. That makes a useless upgrade forced for new users with old state versions. It is also important to state that they must set their package to Nextcloud 18, as future upgrades to Nextcloud will not allow an uprade from 17! I assume future warning messages will exist specifically stating what to do to go from 18 to 19, then 19 to 20, etc...
samueldr
added
the
9.needs: port to stable
| @@ -322,12 +322,21 @@ in { | |||
| Please migrate your configuration to config.services.nextcloud.poolSettings. | |||
| '') | |||
| ++ (optional (versionOlder cfg.package.version "18") '' | |||
| A legacy Nextcloud install (from before NixOS 20.03) may be installed. | |||
There was a problem hiding this comment.
I don't like the wording "legacy Nextcloud install" as it kinda says "legacy nextcloud", but it's "our old kind of setup". Any proposals?
There was a problem hiding this comment.
What I'm thinking here is that the fault lies in our setup of Nextcloud, not in Nextcloud being of an older version.
ofborg
bot
added
6.topic: nixos
I'm pretty sure that this issue will reappear. What if Nextcloud 19 and 20 is available before 20.09? Then we'd have to take extra-care of folks being on Nextcloud 17. Apart from that, this is "just" warning that doesn't keep you from deploying.
I think this is already done by noting that it's not possible to skip multiple major-versions when upgrading.
Yes. I even noted this in the manual btw :) |
samueldr
removed
the
9.needs: port to stable
|
Backported to 20.03 |
Ma27
added
the
8.has: port to stable
|
@samueldr great job, thanks a lot! |
The new wording does not assume the user is upgrading.
This is because a user could be setting up a new installation on 20.03
on a server that has a 19.09 or before stateVersion!!
The new wording ensures that confusion is reduced by stating that they
do not have to care about the assumed 16→17 transition.
Then, the wording explains that they should, and how to upgrade to
version 18.
It also reviews the confusing wording about "multiple" upgrades.
The only thing we cannot really do is stop a fresh install of 17 if
there was no previous install, as it cannot be detected. That makes a
useless upgrade forced for new users with old state versions.
It is also important to state that they must set their package to
Nextcloud 18, as future upgrades to Nextcloud will not allow an uprade
from 17!
I assume future warning messages will exist specifically stating what to
do to go from 18 to 19, then 19 to 20, etc...
cc @Ma27 @worldofpeace
I don't think this is a blocker for 20.03, but something to apply ASAP to 20.03 once approved.