Print float values with full precision. #3480
Draft
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of printing at most 6 digits, print as many digits as are necessary to preserve float values exactly. See also http://www2.open-std.org/JTC1/SC22/WG21/docs/papers/2005/n1822.pdf
|
It's important to note that this change causes evaluation results to diverge between different versions of Nix. But maybe we shouldn't care because few people use floating point anyway. |
|
Is there anything I can do to help getting this merged? |
|
Ping |
|
Any news? |
|
I marked this as stale due to inactivity. → More info |
|
There is a PR related to this #6238, though it's kind of blocked on a solution like NixOS/rfcs#137 |
|
See also #8259: we accidentally made float printing in JSON more precise. I will mention this PR in that issue. |
|
Marking draft because this is old and there are conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing at most 6 digits, print as many digits as are
necessary to preserve float values exactly.
I did run into this when building a config file using nix which has float values requiring at least seven significant digits. With this PR the values are sometimes less pretty, but it is less surprising and makes the float values more versatile.
See also http://www2.open-std.org/JTC1/SC22/WG21/docs/papers/2005/n1822.pdf