Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hobbits: init at 0.52.0 #84856

Merged
merged 1 commit into from Oct 19, 2021
Merged

hobbits: init at 0.52.0 #84856

merged 1 commit into from Oct 19, 2021

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Apr 9, 2020

Motivation for this change

Hobbits - A multi-platform GUI for bit-based analysis, processing, and visualization.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CloudArtAdmins
Copy link
Contributor

This built for me.
Not sure how it works, but the GUI started.

@stale
Copy link

stale bot commented Oct 7, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 7, 2020
@sikmir
Copy link
Member Author

sikmir commented Oct 8, 2020

Keep it.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 8, 2020
pkgs/tools/graphics/hobbits/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/hobbits/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/hobbits/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/hobbits/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Does not build:

peakselector.cpp: In member function 'virtual void PeakSelector::paintEvent(QPaintEvent*)':
peakselector.cpp:69:18: error: aggregate 'QPainterPath path' has incomplete type and cannot be defined
   69 |     QPainterPath path;
      |                  ^~~~

@sikmir
Copy link
Member Author

sikmir commented Jun 1, 2021

0.50.0 is out, there are a lot of changes since 0.23.0.

@sikmir sikmir marked this pull request as draft June 10, 2021 16:40
@sikmir sikmir changed the title hobbits: init at 0.23.0 hobbits: init at 0.51.1 Oct 5, 2021
@sikmir sikmir marked this pull request as ready for review October 5, 2021 22:54
@sikmir sikmir changed the title hobbits: init at 0.51.1 hobbits: init at 0.52.0 Oct 19, 2021
@SuperSandro2000 SuperSandro2000 merged commit 566e536 into NixOS:master Oct 19, 2021
@sikmir sikmir deleted the hobbits branch October 19, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants