Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Make goal question ID use 16 bits again #8072

Merged
merged 1 commit into from Apr 10, 2020
Merged

Fix: Make goal question ID use 16 bits again #8072

merged 1 commit into from Apr 10, 2020

Conversation

ldpl
Copy link
Contributor

@ldpl ldpl commented Apr 10, 2020 •
edited

In 1.10.0 GoalType became 8-bit and so did question id that was for some reason using it.

#regression, #backport-requested ;)

@ldpl ldpl changed the title Fix: Make goal question use 16 bits again Fix: Make goal question ID use 16 bits again Apr 10, 2020
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Apr 10, 2020
glx22
glx22 approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsmh nielsmh merged commit f14a69e into OpenTTD:master Apr 10, 2020
@ldpl ldpl deleted the goal-question-id-uint16 branch April 10, 2020 09:52
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 13, 2020
@ldpl @LordAro
Fix a5681d3: Make goal question ID use 16 bits again (OpenTTD#8072)
2caa8b6
LordAro pushed a commit that referenced this pull request Apr 13, 2020
@ldpl @LordAro
Fix a5681d3: Make goal question ID use 16 bits again (#8072)
eb8d79f
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
@ldpl @douiwby
Fix a5681d3: Make goal question ID use 16 bits again (OpenTTD#8072)
5779336
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ldpl @glx22 @nielsmh @LordAro