Brother MFC6490CW driver #84798
Closed
Brother MFC6490CW driver #84798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@ofborg eval |
Closed
jraygauthier
suggested changes
Apr 10, 2020
There was a problem hiding this comment.
I like this single file packaging. I see this is a hybrid in between the pkgs/misc/cups/drivers/brother/mfcl3770cdw/default.nix single nix file and other lpr / cupswrapper multi nix files packages.
Only issue is with the lpr package name. Also, surround bash variable expansion with double quotes.
|
@jraygauthier Thanks for the review! |
veprbl
reviewed
Mar 23, 2021
| email = "syd@cs-syd.eu"; | ||
| github = "NorfairKing"; | ||
| githubId = 3521180; | ||
| }; |
There was a problem hiding this comment.
The new entries should not go to the end of maintainer-list.nix. Please put them in their respective place according to the alphabetic ordering.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I volunteer to maintain this package as long as I have this printer and use NixOS.
This is my first printer driver and also my first real nixpkgs contribution.
Please be nice, but give a lot of feedback.