Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: 1.14.1 -> 1.14.2 #84801

Merged
merged 1 commit into from May 6, 2020
Merged

go: 1.14.1 -> 1.14.2 #84801

merged 1 commit into from May 6, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 9, 2020

Things done

https://golang.org/doc/devel/release.html#go1.14.minor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! --> ###### Motivation for this change go: 1.14 -> 1.14.2; 1.13.8 -> 1.13.10 Apr 9, 2020
@ofborg ofborg bot requested review from cstrahan, Frostman and kalbasit April 9, 2020 11:05
@FRidh
Copy link
Member

FRidh commented Apr 21, 2020

Merge conflict and needs to target staging.

@FRidh FRidh added this to WIP in Staging via automation Apr 27, 2020
@FRidh FRidh changed the base branch from master to staging April 27, 2020 18:15
@Mic92 Mic92 changed the title go: 1.14 -> 1.14.2; 1.13.8 -> 1.13.10 go: 1.14.1 -> 1.14.2 May 5, 2020
@Mic92 Mic92 merged commit b0f4952 into NixOS:staging May 6, 2020
Staging automation moved this from WIP to Done May 6, 2020
@Mic92 Mic92 deleted the go branch May 6, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants