Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pynanoleaf: init at 0.0.5 #82962

Merged
merged 2 commits into from Apr 10, 2020
Merged

pythonPackages.pynanoleaf: init at 0.0.5 #82962

merged 2 commits into from Apr 10, 2020

Conversation

Oro
Copy link
Contributor

@Oro Oro commented Mar 19, 2020

Motivation for this change

Nanoleaf connectivity for Home Assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

wamserma
wamserma approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the expression seams reasonable, didn't test though

jonringer
jonringer reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82962
2 package built:
python37Packages.pynanoleaf python38Packages.pynanoleaf

pkgs/development/python-modules/pynanoleaf/default.nix Outdated
propagatedBuildInputs = [ requests ];

meta = with lib; {
homepage = https://github.com/Oro/pynanoleaf;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfc 45

Suggested change
homepage = https://github.com/Oro/pynanoleaf;
homepage = "https://github.com/Oro/pynanoleaf";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Force pushed the suggested change

@jonringer jonringer changed the title Pynanoleaf init pythonPackages.pynanoleaf: init at 0.0.5 Mar 31, 2020
jonringer
jonringer reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.


----------------------------------------------------------------------
Ran 0 tests in 0.000s

@Oro
Copy link
Contributor Author

Oro commented Apr 1, 2020

pynanoleaf does not have any unit tests. Force pushed skipping tests and pythonImportsCheck, hope that this is the correct way of handling this! Thanks again for the review

(sidenote: there was a dangling whitespace which presumably got included unintentionally by me after running parse-requirements.py for home-assistant, I also force pushed a clean parse-requirements run here without the dangling whitespace)

@jonringer
Copy link
Contributor

pynanoleaf does not have any unit tests. Force pushed skipping tests and pythonImportsCheck, hope that this is the correct way of handling this! Thanks again for the review

Yes, rebasing and force pushing is the correct way to handle this

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.pynanoleaf

jonringer
jonringer approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/82962
2 package built:
python37Packages.pynanoleaf python38Packages.pynanoleaf

@jonringer jonringer merged commit 6fcf77e into NixOS:master Apr 10, 2020
@jonringer
Copy link
Contributor

Congrats @Oro on your first nixpkgs PR :)

@Oro Oro deleted the pynanoleaf-init branch April 10, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Oro @jonringer @wamserma @Janik-Haag