Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser-bundle-bin: 9.0.7 -> 9.0.9 #84838

Merged
merged 1 commit into from Apr 10, 2020
Merged

tor-browser-bundle-bin: 9.0.7 -> 9.0.9 #84838

merged 1 commit into from Apr 10, 2020

Conversation

andriokha
Copy link
Contributor

Motivation for this change

The current version of tor-browser-bundle-bin is out-of-date, has known security vulnerabilities and is no longer available for download.

Things done

Updated tor-browser-bundle-bin from 9.0.7 to 9.0.9:

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Thanks!

@joachifm joachifm merged commit 383c97d into NixOS:master Apr 10, 2020
@joachifm
Copy link
Contributor

Thank you.

@joachifm
Copy link
Contributor

If you care to, please open a PR against the latest release branch with these commits cherry-picked (using -x to preserve its origin).

This was referenced Apr 10, 2020
Merged
Merged
@andriokha
Copy link
Contributor Author

Thanks @joachifm for the super quick turnaround, and also for shepherding me to do the release PRs - I'm brand new to Nix/NixOS and it really helps!

@andriokha andriokha deleted the tor-browser-bundle-bin-9.0.9 branch April 10, 2020 09:51
@joachifm
Copy link
Contributor

Merged the cherry-picks. Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andriokha @joachifm @Janik-Haag