Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: don't build with -g #84836

Closed
wants to merge 0 commits into from
Closed

protobuf: don't build with -g #84836

wants to merge 0 commits into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 9, 2020

This removes parts of the compiler from the closure.

Motivation for this change

Closes: #73919

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    On darwin:
# nix path-info -Sh $(readlink before)
/nix/store/5vm6cpfhmcdnrp69shllns4qqij213y4-protobuf-3.7.1       693.1M
# nix path-info -Sh $(readlink after)
/nix/store/jd6igaiad4qzjb6salcq7pjgixk2jl2c-protobuf-3.7.1        59.8M

@veprbl
Copy link
Member Author

veprbl commented Apr 9, 2020

on darwin:

# diff -r before/ after/ 
Binary files before/bin/protoc and after/bin/protoc differ
Binary files before/lib/libprotobuf-lite.18.dylib and after/lib/libprotobuf-lite.18.dylib differ
Binary files before/lib/libprotobuf-lite.a and after/lib/libprotobuf-lite.a differ
Binary files before/lib/libprotobuf-lite.dylib and after/lib/libprotobuf-lite.dylib differ
diff -r before/lib/libprotobuf-lite.la after/lib/libprotobuf-lite.la
41c41
< libdir='/nix/store/5vm6cpfhmcdnrp69shllns4qqij213y4-protobuf-3.7.1/lib'
---
> libdir='/nix/store/jd6igaiad4qzjb6salcq7pjgixk2jl2c-protobuf-3.7.1/lib'
Binary files before/lib/libprotobuf.18.dylib and after/lib/libprotobuf.18.dylib differ
Binary files before/lib/libprotobuf.a and after/lib/libprotobuf.a differ
Binary files before/lib/libprotobuf.dylib and after/lib/libprotobuf.dylib differ
diff -r before/lib/libprotobuf.la after/lib/libprotobuf.la
41c41
< libdir='/nix/store/5vm6cpfhmcdnrp69shllns4qqij213y4-protobuf-3.7.1/lib'
---
> libdir='/nix/store/jd6igaiad4qzjb6salcq7pjgixk2jl2c-protobuf-3.7.1/lib'
Binary files before/lib/libprotoc.18.dylib and after/lib/libprotoc.18.dylib differ
Binary files before/lib/libprotoc.a and after/lib/libprotoc.a differ
Binary files before/lib/libprotoc.dylib and after/lib/libprotoc.dylib differ
diff -r before/lib/libprotoc.la after/lib/libprotoc.la
20c20
< dependency_libs=' /nix/store/5vm6cpfhmcdnrp69shllns4qqij213y4-protobuf-3.7.1/lib/libprotobuf.la -lz'
---
> dependency_libs=' /nix/store/jd6igaiad4qzjb6salcq7pjgixk2jl2c-protobuf-3.7.1/lib/libprotobuf.la -lz'
41c41
< libdir='/nix/store/5vm6cpfhmcdnrp69shllns4qqij213y4-protobuf-3.7.1/lib'
---
> libdir='/nix/store/jd6igaiad4qzjb6salcq7pjgixk2jl2c-protobuf-3.7.1/lib'
diff -r before/lib/pkgconfig/protobuf-lite.pc after/lib/pkgconfig/protobuf-lite.pc
1c1
< prefix=/nix/store/5vm6cpfhmcdnrp69shllns4qqij213y4-protobuf-3.7.1
---
> prefix=/nix/store/jd6igaiad4qzjb6salcq7pjgixk2jl2c-protobuf-3.7.1
diff -r before/lib/pkgconfig/protobuf.pc after/lib/pkgconfig/protobuf.pc
1c1
< prefix=/nix/store/5vm6cpfhmcdnrp69shllns4qqij213y4-protobuf-3.7.1
---
> prefix=/nix/store/jd6igaiad4qzjb6salcq7pjgixk2jl2c-protobuf-3.7.1

@veprbl veprbl closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

closure size: protobuf depends on C++ compiler
1 participant
@veprbl