Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CLIHelpers: init at 1.8 #84831

Merged
merged 1 commit into from
Sep 14, 2020
Merged

perlPackages.CLIHelpers: init at 1.8 #84831

merged 1 commit into from
Sep 14, 2020
+16 −0

Conversation

invokesus
Copy link
Contributor

@invokesus invokesus commented Apr 9, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@aanderse
Copy link
Member

aanderse commented Apr 9, 2020

@GrahamcOfBorg build perlPackages.CLIHelpers perldevelPackages.CLIHelpers

@invokesus
Copy link
Contributor Author

Can you rerun ofborg? Not sure why it failed. I'm able to build perlPackages.PerlCritic on nixpkgs-unstable.

@aanderse
Copy link
Member

aanderse commented May 4, 2020

@GrahamcOfBorg build perlPackages.CLIHelpers perldevelPackages.CLIHelpers

stigtsp
stigtsp reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8 is the latest version on CPAN.

Other than that, looks good to me.

@invokesus invokesus force-pushed the contrib/perl-clihelpers branch 2 times, most recently from c32bdad to b4ef842 Compare September 14, 2020 08:40
@invokesus
Copy link
Contributor Author

Thanks for the review @stigtsp. Amended and force-pushed. :)

stigtsp
stigtsp requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @invokesus thx for looking at the PRs again. I've tested your changes on Darwin and Linux and it looks good to me.

Just one small nitpick. The commit message says perlPackage., it should say perlPackages. (plural)

@invokesus invokesus force-pushed the contrib/perl-clihelpers branch from b4ef842 to 612bb9c Compare September 14, 2020 11:46
@invokesus
Copy link
Contributor Author

Thanks for catching that. Fixed now.

@stigtsp stigtsp changed the title perlPackage.CLIHelpers: init at 1.6 perlPackages.CLIHelpers: init at 1.8 Sep 14, 2020
@stigtsp stigtsp merged commit f9a8f94 into NixOS:master Sep 14, 2020
@stigtsp
Copy link
Member

stigtsp commented Sep 14, 2020

@invokesus Thx for the contribution!

@invokesus invokesus deleted the contrib/perl-clihelpers branch September 14, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@invokesus @aanderse @stigtsp