Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcppt: 3.2.2 -> 3.5.0 #84880

Merged
merged 2 commits into from Apr 11, 2020
Merged

fcppt: 3.2.2 -> 3.5.0 #84880

merged 2 commits into from Apr 11, 2020

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

Regular update. Note the added metal dependency. This package isn't in nixpkgs yet. I wasn't sure if I should include it "officially", so it's just an embedded derivation here. Is that okay?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bhipple
bhipple requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's better to do a metal: init at 2.1.1 commit and depend on the pkg cleanly from the distribution, rather than inlining it, unless you're sure that this lib dependency will never be used outside of this one derivation (e.g., it's a private lib).

Also, as a nitpick, we're slowly going through and quoting all of the URLs in fields like meta.homepage for NixOS/rfcs#45

pkgs/development/libraries/fcppt/default.nix Outdated Show resolved Hide resolved
@pmiddend
Copy link
Contributor Author

@bhipple Thanks for the review! I've fixed the things you mentioned.

@bhipple
Copy link
Contributor

bhipple commented Apr 11, 2020

LGTM!

@bhipple
Copy link
Contributor

bhipple commented Apr 11, 2020

Result of nixpkgs-review pr 84880 1

2 packages built:
- fcppt
- metal

@bhipple bhipple merged commit 7b1f4dc into NixOS:master Apr 11, 2020
@pmiddend pmiddend deleted the fcppt-to-3.5.0 branch April 11, 2020 15:55
@pmiddend
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmiddend @bhipple