New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamlPackages.fmt: 0.8.5 → 0.8.6 #84883
Conversation
|
||
stdenv.mkDerivation { | ||
name = "ocaml${ocaml.version}-fmt-0.8.5"; | ||
name = "ocaml${ocaml.version}-fmt-0.8.6"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "ocaml${ocaml.version}-fmt-0.8.6"; | |
pname = "ocaml${ocaml.version}-fmt"; | |
version = "0.8.6"; |
|
||
src = fetchurl { | ||
url = https://erratique.ch/software/fmt/releases/fmt-0.8.5.tbz; | ||
sha256 = "1zj9azcxcn6skmb69ykgmi9z8c50yskwg03wqgh87lypgjdcz060"; | ||
url = https://erratique.ch/software/fmt/releases/fmt-0.8.6.tbz; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url = https://erratique.ch/software/fmt/releases/fmt-0.8.6.tbz; | |
url = "https://erratique.ch/software/fmt/releases/fmt-${version}.tbz;" |
|
||
meta = with stdenv.lib; { | ||
meta = with lib; { | ||
homepage = https://github.com/johnwhitington/ppx_blob; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per NixOS/rfcs#45, unquoted URLs are deprecated, so we're slowly cleaning them up as we go. (Same for the src
URL above.)
Thanks for our comments. I’ve applied your suggestions. |
Result of 3 packages built:- acgtk - jackline - stog |
Motivation for this change
Needed to update alcotest
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)