Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

razergenie: init at 0.8.1 #84812

Merged
merged 2 commits into from Jun 2, 2020
Merged

razergenie: init at 0.8.1 #84812

merged 2 commits into from Jun 2, 2020

Conversation

f4814
Copy link
Contributor

@f4814 f4814 commented Apr 9, 2020

Motivation for this change

Add razergenie, a frontend for the openrazer daemon. To the best of my knowledge there is no openrazer frontend in nixpkgs at the moment, which renders nixos hardware.openrazer functionality almost useless. I also added myself as contributor and notified the RazerGenie maintainers here: z3ntu/RazerGenie#70

I attempted this here #83106 but screwed up my PR. So here is a new, clean PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@f4814 f4814 mentioned this pull request Apr 9, 2020
Closed
10 tasks
@evanjs
Copy link
Member

evanjs commented Apr 9, 2020

Related: #82609
But yes, nothing I've seen at the moment on nixpkgs.
Thanks for the PR!

@evanjs
Copy link
Member

evanjs commented Apr 9, 2020

Anyway, functionality-wise, I can change basic effects, DPI, etc.

I cannot open the "Custom Editor" and image downloads are disabled, so the device thumbnails are not present, though I assume these are known issues.

@f4814
Copy link
Contributor Author

f4814 commented Apr 9, 2020 •
edited

From what I understand the custom editor needs to be supported for your devices (mine are not). Same goes for device thumbnails. When I run it with my hardware it outputs ".png mapping for device 'Razer Goliathus' (PID 3073) missing.". So both are issues we cannot really fix.

etu
etu requested changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code changes and you should split up the addition to the maintainer list to it's own commit.

But other than that it looks good :)

@evanjs
Copy link
Member

evanjs commented Apr 9, 2020

From what I understand the custom editor needs to be supported for your devices (mine are not). Same goes for device thumbnails. When I run it with my hardware it outputs ".png mapping for device 'Razer Goliathus' (PID 3073) missing.". So both are issues we cannot really fix.

Yup! That’s what I figured.
Mamba TE and Huntsman Elite on my end.
This would definitely be enough to help anybody that just wants to “turn off their lights” without dealing with the scripting side of things as documented here.

@f4814
Copy link
Contributor Author

f4814 commented Apr 9, 2020

Fixed the style issues and moved the changes to the maintainers list to another commit.

@f4814 f4814 requested a review from etu April 9, 2020 17:02
@f4814
Copy link
Contributor Author

f4814 commented Jun 1, 2020 •
edited

Any reason not to merge this? @etu

@etu
Copy link
Contributor

etu commented Jun 1, 2020

Mostly me forgetting about this PR 😄

It builds fine, if I run it it just shows a window about something missing:
image

Is this expected?

@f4814
Copy link
Contributor Author

f4814 commented Jun 2, 2020 •
edited

Yes. You need to enable the Openrazer daemon (which provides the API razergenie uses). So if hardware.openrazer.enable is not set (assuming you are using nixos) this is entirely expected.

@etu etu merged commit a823f46 into NixOS:master Jun 2, 2020
@evanjs evanjs mentioned this pull request Jun 2, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f4814 @evanjs @etu