Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

razergenie: init at 0.8.1 #83106

Closed
wants to merge 3,091 commits into from
Closed

razergenie: init at 0.8.1 #83106

wants to merge 3,091 commits into from

Conversation

f4814
Copy link
Contributor

@f4814 f4814 commented Mar 21, 2020

Motivation for this change

Add razergenie, a frontend for the openrazer daemon. To the best of my knowledge there is no openrazer frontend in nixpkgs at the moment, which renders nixos hardware.openrazer functionality almost useless. I also added myself as contributor and notified the RazerGenie maintainers here: z3ntu/RazerGenie#70

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor
Copy link
Member

Emantor commented Apr 6, 2020

Hi, this needs a rebase onto master to resolve the merge conflict.

r-ryantm and others added 24 commits April 7, 2020 12:00
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Neither --qt nor --xdg are supported anymore.
This puts all emacs-related binaries and code to a separate output,
removing emacs from the runtime closure of neomutt.
@f4814
Copy link
Contributor Author

f4814 commented Apr 9, 2020

Okay. This was not what I intended to to. I'll just close this PR and create a new clean one.

@f4814 f4814 closed this Apr 9, 2020
@Emantor
Copy link
Member

Emantor commented Apr 9, 2020

@f4814 Unfortunately you didn't rebase, you merged the master branch into your branch. https://git-rebase.io/ has a great description on how to do rebases.

@f4814
Copy link
Contributor Author

f4814 commented Apr 9, 2020

Thanks for the link. I am fairly new to contributing in such a way. I'll quickly create a new, clean PR.

@f4814 f4814 deleted the razergenie-init branch April 9, 2020 13:20
@f4814 f4814 mentioned this pull request Apr 9, 2020
10 tasks
@f4814
Copy link
Contributor Author

f4814 commented Apr 9, 2020

Okay. New, clean PR is #84812 Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet