Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] unit: 1.14.0 -> 1.16.0 #84840

Merged
merged 2 commits into from Apr 10, 2020
Merged

[20.03] unit: 1.14.0 -> 1.16.0 #84840

merged 2 commits into from Apr 10, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Apr 9, 2020

Motivation for this change

Unit fails to build on 20.03, but builds fine on master.
The issues seems to be some ruby incompatibility, which was fixed upstream.
The version upgrades are both picked from master.

cc @Izorkin

#80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r-ryantm and others added 2 commits April 9, 2020 20:46
@r-ryantm @ajs124
unit: 1.14.0 -> 1.15.0
4efd728 
(cherry picked from commit 3815de8)
@Izorkin @ajs124
unit: 1.15.0 -> 1.16.0
56eb406 
(cherry picked from commit 5dbe01a)
@ofborg ofborg bot requested a review from Izorkin April 9, 2020 19:01
@bhipple
Copy link
Contributor

bhipple commented Apr 10, 2020

Result of nixpkgs-review pr 84840 1

1 package built:
- unit

@bhipple bhipple merged commit f19157d into NixOS:release-20.03 Apr 10, 2020
@ajs124 ajs124 deleted the backport/20.03/unit branch April 10, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@Izorkin Izorkin Izorkin approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @bhipple @Izorkin @r-ryantm