pythonPackages.salmon-mail: 3.1.1 -> 3.2.0 #82166
Conversation
ofborg
bot
added
6.topic: python
11.by: package-maintainer
|
@GrahamcOfBorg build python37Packages.salmon-mail |
|
|
||
| # The tests use salmon executable installed by salmon itself so we need to add | ||
| # that to PATH | ||
| checkPhase = '' | ||
| PATH=$out/bin:$PATH nosetests . | ||
| PATH=$out/bin:$PATH python setup.py test |
There was a problem hiding this comment.
getting some failures:
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/446ahn0w3b5b7dqh1245hc55pcfsxbvj-python3.7-salmon-mail-3.2.0.drv' failed with exit code 1; last 10 log lines:
File "/build/salmon-mail-3.2.0/salmon/routing.py", line 503, in routing_wrapper
next_state = func(message, *args, **kw)
TypeError: END() got an unexpected keyword argument 'anything'
----------------------------------------------------------------------
Ran 147 tests in 2.561s
FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
builder for '/nix/store/bl0xb0l6dmvkw46cq75dw5axzan75cxn-python3.8-salmon-mail-3.2.0.drv' failed with exit code 1; last 10 log lines:
File "/build/salmon-mail-3.2.0/salmon/routing.py", line 503, in routing_wrapper
next_state = func(message, *args, **kw)
TypeError: END() got an unexpected keyword argument 'anything'
----------------------------------------------------------------------
Ran 147 tests in 2.294s
FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
cannot build derivation '/nix/store/j798yif7088svypcji7mzqqywq71dyw4-env.drv': 2 dependencies couldn't be built
There was a problem hiding this comment.
Well, that's weird.. This builds fine on my machine:
$ nix-build '<nixpkgs>' -A python37Packages.salmon-mail
/nix/store/p701xnxwrwvhg8pc76m02z29923lgxv1-python3.7-salmon-mail-3.2.0
What could cause the difference? Difficult to fix if I'm not able to reproduce..
There was a problem hiding this comment.
I now rebased on nixos-unstable. Still building fine on my machine...
There was a problem hiding this comment.
I'll come in as a neutral third party and say this builds just fine on my machine as well:
[4 built, 7 copied (2.1 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82166
2 package built:
python37Packages.salmon-mail python38Packages.salmon-mail
That said, the OfBorg build is failing on Darwin:
start explode localhost
EXPLODE!
Relay: <Relay to (localhost:0)>
error: Test failed: <unittest.runner.TextTestResult run=147 errors=0 failures=1>
builder for '/nix/store/dwdzz3r1j5abi09g48x6mhf5r406gy4r-python3.7-salmon-mail-3.2.0.drv' failed with exit code 1
There was a problem hiding this comment.
Hmm.. Should I try if __darwinAllowLocalNetworking = true; fixes build on Darwin?
There was a problem hiding this comment.
I now added that flag. Let's see if it helps. How can I use OfBorg to try building again for Darwin to see if it helped?
jluttine
force-pushed
the
salmon-mail-3.2.0
branch
from
19135fe to
6546af6
Compare
|
@GrahamcOfBorg build python37Packages.salmon-mail |
jluttine
force-pushed
the
salmon-mail-3.2.0
branch
from
6546af6 to
ef86430
Compare
There was a problem hiding this comment.
still getting failures
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/mhfi91xvxccgwmv792a12xh9nkfk3dd7-python3.8-salmon-mail-3.2.0.drv' failed with exit code 1; last 10 log lines:
File "/build/salmon-mail-3.2.0/salmon/routing.py", line 503, in routing_wrapper
next_state = func(message, *args, **kw)
TypeError: END() got an unexpected keyword argument 'anything'
----------------------------------------------------------------------
Ran 147 tests in 1.510s
FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
builder for '/nix/store/kd08nimwdzb8kk7nm7h160d8f35cs4bi-python3.7-salmon-mail-3.2.0.drv' failed with exit code 1; last 10 log lines:
File "/build/salmon-mail-3.2.0/salmon/routing.py", line 503, in routing_wrapper
next_state = func(message, *args, **kw)
TypeError: END() got an unexpected keyword argument 'anything'
----------------------------------------------------------------------
Ran 147 tests in 1.729s
FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=147 errors=1 failures=0>
cannot build derivation '/nix/store/aacgrwnl5b8pw7fsm271w6iwq6b3aw4m-env.drv': 2 dependencies couldn't be built
can you check to see if you have anything in your overlay
|
@GrahamcOfBorg build python3Packages.salmon-mail |
|
@jonringer If I understand correctly, OfBorg builds fine for Linux, also it builds fine on my machine and also @bhipple machine. I'd need to be able to reproduce the failure in order to fix it. Could you share the command you used to build which resulted in the failure? But if it builds fine on OfBorg, isn't that then ok? Apparently, Darwin is still failing, so I guess I should either disable tests for Darwin or disable the whole package for Darwin. Any suggestions? |
|
if any one of these: |
|
Looking at the test suite, mine looks like a legitimate error. The dummy Also doesn't help that his test suite is hand done, and not using a normal testing framework |
|
@jonringer I still don't understand why the build works for me if it's not supposed to. I ran nixpkgs review and it shows all good: Could you share the explicit command that you use to reproduce the build failure? I want to understand what I'm doing wrong here if this is not supposed to build fine on Linux. |
|
I have no idea either. I'm just going to mentally blacklist the package for my machine. Maybe it's because it's a ryzen3, who knows? not I |
Motivation for this change
Upgrade Python package salmon-mail.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)